Fixed dlhn benchmark to work properly #6
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for choosing dlhn as a benchmark target. I have made the following changes to make the dlhn benchmark work:
LargeStruct
map field fromHashMap<u32, u64>
, toHashMap<String, u64>
. This is because dlhn can only use strings as Map types.benches!(serde_cbor);
, which was commented out along with the fixme comment.I hope that these changes will help improve the benchmarking process for musli. Thank you for your support and understanding.