Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug/fix dumps jinja issue #477

Merged
merged 12 commits into from
Jan 28, 2022

Conversation

srecinto
Copy link
Contributor

pulled out dumps from jinja and applied fix for double quotes in the main mappings

@srecinto srecinto added the type: bug Something isn't working label Jan 27, 2022
@noinarisak
Copy link
Contributor

@srecinto The dumps introduced by @RyAndrew was to resolve the escape issue, detailed in #456. Based on this PR, I think you are bringing the bug back.

Copy link
Contributor

@noinarisak noinarisak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please review

utils/okta.py Outdated Show resolved Hide resolved
Copy link
Contributor

@noinarisak noinarisak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GTG!

@sonarcloud
Copy link

sonarcloud bot commented Jan 28, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@noinarisak noinarisak merged commit 8b474aa into udplabs:master Jan 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants