Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix submit button bug on the factor screen #479

Merged
merged 6 commits into from
Jan 28, 2022
Merged

Fix submit button bug on the factor screen #479

merged 6 commits into from
Jan 28, 2022

Conversation

noinarisak
Copy link
Contributor

@noinarisak noinarisak commented Jan 27, 2022 •
edited
Loading

  • Remove reference to zartan cdn and commit the mfa_enrollment.js to the repo.
  • Enable the Add Factor button.

@noinarisak noinarisak added the type: bug Something isn't working label Jan 27, 2022
@sonarcloud
Copy link

sonarcloud bot commented Jan 28, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 14 Code Smells

No Coverage information No Coverage information
8.4% 8.4% Duplication

srecinto
srecinto approved these changes Jan 28, 2022
View reviewed changes
Copy link
Contributor

@srecinto srecinto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These look good

@srecinto srecinto merged commit b79751f into udplabs:master Jan 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srecinto srecinto srecinto approved these changes

Assignees

@noinarisak noinarisak

@srecinto srecinto

Labels
type: bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@noinarisak @srecinto