Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make Suggestion extension use view.dom instead of document #3093

Merged
merged 1 commit into from
Aug 22, 2022
Merged

Make Suggestion extension use view.dom instead of document #3093

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/suggestion/src/suggestion.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,7 @@ export function Suggestion<I = any>({
const state = handleExit && !handleStart
? prev
: next
const decorationNode = document.querySelector(`[data-decoration-id="${state.decorationId}"]`)
const decorationNode = view.dom.querySelector(`[data-decoration-id="${state.decorationId}"]`)

props = {
editor,
Expand All @@ -122,7 +122,7 @@ export function Suggestion<I = any>({
? () => {
// because of `items` can be asynchrounous we’ll search for the current docoration node
const { decorationId } = this.key?.getState(editor.state) // eslint-disable-line
const currentDecorationNode = document.querySelector(`[data-decoration-id="${decorationId}"]`)
const currentDecorationNode = view.dom.querySelector(`[data-decoration-id="${decorationId}"]`)

return currentDecorationNode?.getBoundingClientRect() || null
}
Expand Down