Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

prevent opening link when clicking on selection containing a link #4346

Merged
merged 2 commits into from
Sep 4, 2023
Merged

prevent opening link when clicking on selection containing a link #4346

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fae596c
prevent opening link when clicking on selection containing a link
aldinezi Aug 18, 2023
51ce85a
Fix lint err
aldinezi Aug 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions packages/extension-link/src/helpers/clickHandler.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,12 @@ export function clickHandler(options: ClickHandlerOptions): Plugin {
return false
}

const eventTarget = event.target as HTMLElement

if (eventTarget.nodeName !== 'A') {
aldinezi marked this conversation as resolved.
Show resolved Hide resolved
return false
}

const attrs = getAttributes(view.state, options.type.name)
const link = (event.target as HTMLLinkElement)

Expand Down