fix: allowing 'ref' access for 'EditorContent' in react #4471
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for tiptap-embed ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
2 tasks
|
Can this be reviewed and merged? |
janthurau
force-pushed
the
fix/accessing-editor-content-with-ref-react
branch
from
2f8e3f7
to
cb1668d
Compare
|
Resolved with: #4396 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe your changes
Adding
forwardReftoEditorContentWithKeyHow did you accomplish your changes
by adding a
forwardRefonEditorContentWithKeyHow have you tested your changes
By creating my own version of
EditorContentWithKeywithforwardRefand testing it in my project.How can we verify your changes
Use the new version with
refonEditorContentand it should not throw any warning/errors for using ref on afunctionalcomponent.Remarks
[add any additional remarks here]
Checklist
Related issues
#4470