Update selected props only needed #4650
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for tiptap-embed ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Would be great to have anything that improves React performance. |
|
This seems to have been fixed in #4661 which is released in 2.1.13 |
|
yes! Should be fixed by #4661. Let us know if the issue persists. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe your changes
I experienced a performance degradation in my app after I upgraded Tiptap to 2.1.12. I found an issue about this at #4492 and discovered a monkey patch, but it appears that nobody has sent a PR for it.
How did you accomplish your changes
I stopped calling
this.renderer.updatePropsunnecessary.How have you tested your changes
I tested on my local environment.
How can we verify your changes
Before
Screen.Recording.2023-11-24.at.10.43.23.mov
After
Screen.Recording.2023-11-24.at.10.41.09.mov
Remarks
[add any additional remarks here]
Checklist
Related issues
#4492