Fix/link pasting #4700
Merged
Fix/link pasting #4700
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for tiptap-embed ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
@bdbch looks like there are some failing tests, have you looked into those? |
|
Just figured out that there a few small bugs with link pasting and validation when using the validate option. I now work on this and will probably get this out too tomorrow. |
|
Looking at this, it looks like it would resolve the need for #4587 as well? |
|
@C-Hess I think it does. I'll check again afterwards |
Closed
2 tasks
2 tasks
stevobm
reviewed
Jan 27, 2024
| @@ -26,6 +26,10 @@ export function getMarksBetween(from: number, to: number, doc: ProseMirrorNode): | |||
| }) | |||
| } else { | |||
| doc.nodesBetween(from, to, (node, pos) => { | |||
| if (!node || node.nodeSize === undefined) { | |||
There was a problem hiding this comment.
This change caused a bug: #4785
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe your changes
This PR fixes issues with paste handling and autolinking with the current version of the Link extension. I refactored the pasting and autolink plugins, reverted my changes from a few months ago to the one before and updated this to support all cases I wanted to fix back then.
To make my changes happen I had to add the clipboard event to the PasteRule handlers. I think this could also be benefitial for other users in the future.
How did you accomplish your changes
How have you tested your changes
I added necessary tests - but you can also check the feature on the Link preview
How can we verify your changes
I added necessary tests - but you can also check the feature on the Link preview
Checklist
Related issues
closes #4627
closes #4541
closes #4484
closes #3634