Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drawing not cleared after submitting the feedback #46

Closed
vintage opened this issue Mar 17, 2021 · 4 comments
Closed

Drawing not cleared after submitting the feedback #46

vintage opened this issue Mar 17, 2021 · 4 comments

Comments

@vintage
Copy link

vintage commented Mar 17, 2021

Hey @ueman! 👋

After submitting new feedback (message+drawing) and opening the form again through BetterFeedback.of(context).show the message is indeed cleared, but the drawing shows the one from previous feedback.

I would expect it got cleared as well as the message.

@ueman
Copy link
Owner

ueman commented Mar 17, 2021

Hey @vintage,
thanks for your feedback.
Which version of the library are you using?

@vintage
Copy link
Author

vintage commented Mar 17, 2021

Installed today the latest available version:

feedback:
    dependency: "direct main"
    description:
      name: feedback
      url: "https://pub.dartlang.org"
    source: hosted
    version: "1.0.1"
flutter doctor -v
[✓] Flutter (Channel stable, 2.0.2, on macOS 11.2.3 20D91 darwin-x64, locale en-GB)
    • Flutter version 2.0.2 at /usr/local/opt/flutter
    • Framework revision 8962f6dc68 (6 days ago), 2021-03-11 13:22:20 -0800
    • Engine revision 5d8bf811b3
    • Dart version 2.12.1

[✓] Android toolchain - develop for Android devices (Android SDK version 29.0.2)
    • Android SDK at /Users/kamil/Library/Android/sdk/
    • Platform android-30, build-tools 29.0.2
    • ANDROID_SDK_ROOT = /Users/kamil/Library/Android/sdk/
    • Java binary at: /Applications/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b3-6915495)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Xcode 12.4, Build version 12D4e
    • CocoaPods version 1.10.1

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 4.1)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b3-6915495)

[✓] VS Code (version 1.54.2)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.20.0

[✓] Connected device (2 available)
    • Android SDK built for x86 (mobile) • emulator-5554 • android-x86    • Android 10 (API 29) (emulator)
    • Chrome (web)                       • chrome        • web-javascript • Google Chrome 89.0.4389.90
    ! Error: iPhone is not connected. Xcode will continue when iPhone is connected. (code -13)

• No issues found!

@ueman
Copy link
Owner

ueman commented Mar 18, 2021

I'll try to make some time in the next few days. I'll also be happy to accept a PR if you're interested in doing it yourself.

ueman added a commit that referenced this issue Mar 21, 2021
@ueman ueman closed this as completed in 6f2694b Mar 21, 2021
@ueman
Copy link
Owner

ueman commented Mar 21, 2021

This is now fixed in version 1.0.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants