adds an exposed sheet contorller to the better feedback controller #239
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Description
This PR exposes a
DraggableScrollableController
fromFeedbackController
.This was a PR I intended to do a long time ago, but it was blocking on a PR landing in
flutter/flutter
and that took so long that I forgot to get back to this ):I have a handful of TODOs in other places that this PR unblocks, but I figured I'd do those in a follow up PR as they're much fussier and harder to land.
💡 Motivation and Context
This PR allows users of
BetterFeedback
to listen to the state of the feedback sheet and manually manipulate it. This is useful for things like:💚 How did you test it?
📝 Checklist
🔮 Next steps
sheetProgress
in the places where it is used with a direct reference to the sheet controller(blocking on a PR to add
double get progress
to flutter/flutter Addprogress
,sizeToprogress
andprogressToSize
toDraggableScrollableSheet
flutter/flutter#135366)