Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Submit button style as per activeFeedbackModeColor #249

Merged
merged 3 commits into from
Nov 5, 2023
Merged

Submit button style as per activeFeedbackModeColor #249

merged 3 commits into from
Nov 5, 2023

Conversation

rohitbhoite
Copy link
Contributor

@rohitbhoite rohitbhoite commented Oct 28, 2023 •
edited by ueman
Loading

📜 Description

Fixes #245

💡 Motivation and Context

💚 How did you test it?

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • I updated the docs if needed
  • All tests passing
  • No breaking changes

🔮 Next steps

@rohitbhoite rohitbhoite mentioned this pull request Oct 28, 2023
Closed
ueman
ueman requested changes Oct 31, 2023
View reviewed changes
Copy link
Owner

@ueman ueman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add some more context to this? Why should the text have this specific text style?

feedback/lib/src/feedback_builder/string_feedback.dart Outdated
child: Text(FeedbackLocalizations.of(context).submitButtonText,
style: TextStyle(
color: FeedbackTheme.of(context).activeFeedbackModeColor,
)),
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
)),
),),

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Basically, I am trying to fix #245 which will allow Submit button Color to be configurable

@rohitbhoite
Copy link
Contributor Author

On my Local all tests are passing after updating golden images

@ueman
Copy link
Owner

ueman commented Nov 1, 2023

On my Local all tests are passing after updating golden images

Are you developing on a Windows computer or on a Mac? If you're developing on a Windows machine that's probably the cause. In that case I'll update the golden images after merging.

@rohitbhoite
Copy link
Contributor Author

On my Local all tests are passing after updating golden images

Are you developing on a Windows computer or on a Mac? If you're developing on a Windows machine that's probably the cause. In that case I'll update the golden images after merging.

yes I am using windows :).

@rohitbhoite
Copy link
Contributor Author

rohitbhoite commented Nov 5, 2023 •
edited
Loading

@ueman Please let let me know if i should update PR without golden images or it can be merged with current changes

@ueman ueman merged commit 98e05cd into ueman:master Nov 5, 2023
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ueman ueman ueman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use the Theme data to style the 'Submit' button
2 participants
@rohitbhoite @ueman