Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(translation): add Spanish support in localization delegate #284

Merged
merged 1 commit into from
Mar 6, 2024

Conversation

RhoBus
Copy link
Contributor

@RhoBus RhoBus commented Mar 6, 2024

📜 Description

Only translation file is affected with this change, it adds Spanish language as supported by delegate with the default translation.

💡 Motivation and Context

This should close request #283 to add Spanish support on default feedback

💚 How did you test it?

  • Modifying the example locale to 'es'.
  • Testing with a physical device

📝 Checklist

  • I reviewed submitted code
  • [ ] I added tests to verify changes
  • [ ] I updated the docs if needed
  • [ ] All tests passing
  • No breaking changes

🖼️ Screenshot

image

@RhoBus RhoBus requested a review from ueman as a code owner March 6, 2024 13:06
@RhoBus
Copy link
Contributor Author

RhoBus commented Mar 6, 2024

Please let me know if I'm missing something. 🤜 🤛

@ueman
Copy link
Owner

ueman commented Mar 6, 2024

Please let me know if I'm missing something. 🤜 🤛

Nah, this seems fine. Thanks for translating it.

Copy link

codecov bot commented Mar 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.77%. Comparing base (471cc7b) to head (100900b).
Report is 4 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #284   +/-   ##
=======================================
  Coverage   83.77%   83.77%           
=======================================
  Files          20       20           
  Lines         635      635           
=======================================
  Hits          532      532           
  Misses        103      103           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ueman ueman merged commit a86d6ab into ueman:master Mar 6, 2024
8 checks passed
@RhoBus RhoBus deleted the feature/spanish-support branch March 6, 2024 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants