feat(passkit_server): Passkit Backend #76
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ueman
changed the title
ueman
commented
Sep 1, 2024
Comment on lines
+8
to
+25
| extension PasskitServerExtension on Router { | ||
| void addPassKitServer(PassKitBackend backend) { | ||
| post( | ||
| '/v1/devices/<deviceID>/registrations/<passTypeID>/<serial>', | ||
| setupNotifications(backend), | ||
| ); | ||
| get( | ||
| '/v1/devices/<deviceID>/registrations/<typeID>', | ||
| getListOfUpdatablePasses(backend), | ||
| ); | ||
| delete( | ||
| '/v1/devices/<deviceID>/registrations/<passTypeID>/<serial>', | ||
| stopNotifications(backend), | ||
| ); | ||
| get('/v1/passes/<identifier>/<serial>', getLatestVersion(backend)); | ||
| post('/v1/log', logMessages(backend)); | ||
| } | ||
| } |
There was a problem hiding this comment.
This should probably be a shelf routing middleware. That ensures better compatibility with dart_frog. For shelf_router compatibility should still be maintained though, but I guess that's easy enough to do and requires just some documentation or example code. That way, this package also doesn't depend on the shelf_router package itself.
References:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #12