Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let lonely modifiers pass through if no command assigned #64

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

lo48576
Copy link
Contributor

@lo48576 lo48576 commented Sep 23, 2018

This change prevents modifiers, "Control_L" without normal key for
example, from being eaten by libskk.

This is essentially doing same thing as 10555a2, except for returning false to let modifiers pass through.

This change prevents modifiers, "Control_L" without normal key for
example, from being eaten by libskk.
@lo48576
Copy link
Contributor Author

lo48576 commented Sep 23, 2018

In my environment, modifiers such as Control_L causes unexpected behaviour without this patch.

Using fcitx-skk and libskk-1.0.5:

p o c Bksp →ぽ
p o c Ctrl → ぽc
p o c Ctrl Bksp Bksp →ぽc
p o c Ctrl a →ぽあ
p o c C-h Bksp a →ぽあ

This patch fixes behaviour in these cases (and it work as expected in my env.)

I can't reproduce this problem by using skk command, and I don't know how to write tests for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant