Instant translation #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
That's awesome! Looks slick and neat. |
uetchy
requested changes
Aug 5, 2018
Polyglot.safariextension/Info.plist
Outdated
| <key>CFBundleVersion</key> | ||
| <string>2.3.0</string> | ||
| <string>2.4.0</string> |
There was a problem hiding this comment.
I'd like to add some another bugfix to Polyglot before releasing next version so would be great if there is no version bump commit in this PR!
I cannot modify your commit so could you remove lines related to version bumps?
There was a problem hiding this comment.
or just discard version bumps commit :)
There was a problem hiding this comment.
@uetchy sure, I'll change it back 👌
uetchy
approved these changes
Aug 5, 2018
|
merged! |
|
Thanks a lot |
|
@uetchy can we please make a new public release soon? |
|
See v2.4.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First of all, thanks for the extension.
In this pull request I would like to suggest a new setting to translate the selected text instantly. When you select some text on a page or double-click on a word this selection can be translated. I think this is a very useful feature, I would prefer to use this opportunity.