Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rewrite in Swift #53

Merged
merged 119 commits into from
Jul 11, 2019
Merged

Rewrite in Swift #53

merged 119 commits into from
Jul 11, 2019

Conversation

uetchy
Copy link
Owner

@uetchy uetchy commented Jul 1, 2019 •
edited by kazuyaikoma
Loading

Polyglot

  • Automatic language field filling
  • Save language preferences in a country code
  • Instant Translation preference
  • Restore saved prefs

PolyglotSafariExtension

  • Message passing
  • Translate received text and get back to the script

@uetchy uetchy changed the title [WIP] Rewrite in Swift Rewrite in Swift Jul 9, 2019
kazuyaikoma
kazuyaikoma reviewed Jul 11, 2019
View reviewed changes
Polyglot/AppDelegate.swift
recordView.backgroundColor = .controlBackgroundColor
recordView.borderColor = .controlShadowColor
}
}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

kazuyaikoma
kazuyaikoma reviewed Jul 11, 2019
View reviewed changes
README.md
- Sergey Sorokin
- Serhii Dmytruk
- Matt Sephton
- nixiesquid
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yay!
Thanks a lot :)

kazuyaikoma
kazuyaikoma approved these changes Jul 11, 2019
View reviewed changes
Copy link
Collaborator

@kazuyaikoma kazuyaikoma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nichijou2

@uetchy uetchy merged commit 2d63c4d into master Jul 11, 2019
@uetchy
Copy link
Owner Author

uetchy commented Jul 11, 2019

Merged

@gingerbeardman
Copy link
Collaborator

Congrats! Excellent work.

@uetchy uetchy deleted the mas branch July 18, 2019 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kazuyaikoma kazuyaikoma kazuyaikoma approved these changes

Assignees

@uetchy uetchy

@kazuyaikoma kazuyaikoma

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@uetchy @gingerbeardman @kazuyaikoma