Add option to show button to confirm instant translation #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidyuk
commented
Feb 28, 2021
| @@ -3,13 +3,21 @@ | |||
| --background: rgba(200, 200, 200, 0.7); | |||
| --text: #2b2b2b; | |||
| } | |||
|
|
|||
| .polyglot__confirm-button img { | |||
| filter: invert(11%) sepia(0%) saturate(61%) hue-rotate(286deg) brightness(98%) contrast(84%); | |||
There was a problem hiding this comment.
This is generated by https://stackoverflow.com/a/50942954/6176994
I don't know a better solution, except:
- convert icon to SVG and use
currentColor - or add icon image twice with the necessary colors
There was a problem hiding this comment.
svg sounds better, but for now your solution is plausible enough.
|
Thank you for the PR, it looks super lit! |
uetchy
approved these changes
Mar 12, 2021
|
Testing for a couple of days, I found no major issues on this patch. |
|
PSA: This feature has landed on Mac App Store version of Polyglot. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have used Google Translate extension in Chrome before, and I liked the option to show a small button when some text selected for translation confirmation. I miss that feature in this extension and proposing its implementation here.
Currently, I'm using Polyglot in "Instant Translation" mode it works fine except:
As an alternative to this, I have found the context menu option to invoke translation of the selected text. This is close to the feature I'm proposing to implement, but from my perspective, the current feature is a bit more accessible.
I have added one switch in the settings:
The designs and wording is quite a draft. Probably would be more reasonable to use a Combobox with values like "Disable Instant Translation"/"Instant Translation with confirmation"/"Instant Translation". But don't want to deal with settings migrations at least at the current step.
The translation confirmation button looks this way:
It shows near the cursor. It works well in most cases, except when a long paragraph is selected from the end to the beginning.