Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uca camera state read from camera #409

Merged
merged 3 commits into from
Apr 4, 2022
Merged

Uca camera state read from camera #409

merged 3 commits into from
Apr 4, 2022

Conversation

MarcusZuber
Copy link
Member

This reads the state of the camera from the uca device instead storing it in the local concert session.
This helps when using uca-net devices where the state can be out of sync to the state concert assumes.

@MarcusZuber MarcusZuber self-assigned this Apr 4, 2018
@MarcusZuber
Copy link
Member Author

Together with ufo-kit/uca-net@fe803be it should work

@MarcusZuber
Copy link
Member Author

@tfarago On my pc at home it works. We should test this soon with real cameras.
This will save me so many phone calls...

@tfarago
Copy link
Contributor

tfarago commented Apr 2, 2020

Why is the interface different in the first place? If that cannot be changed then we can proceed with this...

@MarcusZuber
Copy link
Member Author

The different interface has something to do where the command is executed (in the local net-plugin or in the remote plugin). The state is handled in the parent class of the net-plugin, which does not synchronize with the parent class of the server-side-plugin. This do_ function explicitly call the function of the server-side and uses the state on the server.
I'm currently not deep enough in the uca and glib stuff to make this more elegant in uca-net.
If you don't want to change the uca-net code further I would proceed with this implemention.

@tfarago
Copy link
Contributor

tfarago commented Apr 2, 2020

alright 👍

@tfarago
Copy link
Contributor

tfarago commented Apr 13, 2021

@MarcusZuber does this still work? Can I merge?

@MarcusZuber
Copy link
Member Author

I would like to do further tests with different hardware.
I would propose to postpone this after the python3 conversion.

@tfarago
Copy link
Contributor

tfarago commented Apr 13, 2021

Alright

@MarcusZuber MarcusZuber mentioned this pull request Mar 18, 2022
@tfarago
Copy link
Contributor

tfarago commented Mar 18, 2022

This needs libuca#44 because right now even uca.is_recording is not synced with the real remote camera.

@tfarago tfarago force-pushed the fix-uca-state branch 2 times, most recently from 034044f to 4844808 Compare March 18, 2022 16:59
@MarcusZuber
Copy link
Member Author

This looks so clean. Are you sure it works? 😉

@tfarago
Copy link
Contributor

tfarago commented Mar 18, 2022

Now it should work.

@tfarago
Copy link
Contributor

tfarago commented Mar 18, 2022

And it also needs this

@tfarago tfarago changed the title [WIP] Uca camera state read from camera Uca camera state read from camera Apr 1, 2022
@tfarago tfarago merged commit 3c53930 into master Apr 4, 2022
@tfarago tfarago deleted the fix-uca-state branch April 4, 2022 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants