-
Notifications
You must be signed in to change notification settings - Fork 243
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ufs_public_release: update version number for CCPP, disable dynamic CCPP, cleanup work and bug fixes for regression tests #25
Conversation
…ons, run scripts and namelist templates - add CCPP and IPD regression tests for comparison in REPRO mode - disable inline post on all supported platforms - fix regression tests: correct run scripts, check for output from tests in debug mode - convert namelist templates to unix line endings - disable dynamic CCPP build - update date tag for regression test baseline
Associated PRs: NCAR/ccpp-framework#247 |
New regression test baselines have been created on Cheyenne and are currently located in:
On hera, they are in:
Once the code review is complete, I can rename the Cheyenne baseline and EMC will need to move the Hera baseline into the right place before running the regression tests once more and updating the logs in the ufs-weather-model PR. |
… for cheyenne.gnu, update regression baseline date tag
753c435
to
6911d3a
Compare
All regression tests have passed and the logs have been updated in the PR. |
98f9b87
to
059a110
Compare
059a110
to
014ceda
Compare
@DusanJovic-NOAA this is ready from my side. Took me three attempts to revert the |
…_other_updates Add drag suite and other updates
Bugfix for regional runs when dycore is compiled in double precision
…for which to build FV3 from valid_vals_CCPP_PHYS_SUITES (#25) This PR must be merged at the same time as PR #[301](https://github.com/NOAA-EMC/regional_workflow/pull/301) into NOAA-EMC/regional_workflow. ## DESCRIPTION OF CHANGES: * For stability, freeze version of UFS_UTILS in Externals.cfg to a specific hash. * In build_forecast.sh, get the list of CCPP physics suites for which to build the FV3 executable from the array valid_vals_CCPP_PHYS_SUITES in the file valid_param_vals.sh in regional_worfklow. * Delete build_global_equiv_resol.sh and build_mosaic_file.sh since those scripts are no longer needed. The mosaic_file code has been removed, and the global_equiv_resol code is now in UFS_UTILS and is built in/by that repo. * For consistency with the name of the code, change the name of the executable for building a regional grid that gets copied to ufs-srweather-app/exec from regional_grid to regional_esg_grid. * Remove unneeded lines from regional_build.cfg. ## TESTS CONDUCTED: See PR #[301](https://github.com/NOAA-EMC/regional_workflow/pull/301) into NOAA-EMC/regional_workflow for tests conducted.
With these changes,
Known issue: The results differ between the IPD and CCPP tests in REPRO mode on Cheyenne using the GNU compiler for 24hr fcst runs. I have not tested if the results are still identical after 1hr (since they are on macOS). For this reason, the IPD verification against the CCPP results in REPRO mode are turned off for Cheyenne+GNU.