Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Unstructured WW3 mesh capability to UFS #1727

Merged
merged 43 commits into from
May 15, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
43 commits
Select commit Hold shift + click to select a range
9837683
update WW3 to current add_unstr branch
DeniseWorthen Apr 19, 2023
95a7ced
update test harness
DeniseWorthen Apr 19, 2023
67282bd
remove extra wav task setting
DeniseWorthen Apr 19, 2023
07de5e8
fix restart file names
DeniseWorthen Apr 19, 2023
f61485d
b4b on hera.intel
DeniseWorthen Apr 20, 2023
d9097cd
add scotch library to ufs_common
DeniseWorthen Apr 20, 2023
8f1a8db
update WW3 branch
DeniseWorthen Apr 26, 2023
174c728
update testing rt file
DeniseWorthen Apr 26, 2023
ef03f30
remove "wise" from wave domain name
DeniseWorthen Apr 26, 2023
fc70912
Merge remote-tracking branch 'origin/develop' into feature/add_unstr
DeniseWorthen Apr 26, 2023
74b4597
update WW3, modify rtwaves for testing
DeniseWorthen Apr 26, 2023
cf0c099
all rt.wave baselines pass against test bl on orion
DeniseWorthen Apr 26, 2023
30bbbef
all rt.wave baselines pass cheyenne.intel
DeniseWorthen Apr 27, 2023
21b16d9
Merge branch 'feature/add_unstr' of https://github.com/DeniseWorthen/…
DeniseWorthen Apr 27, 2023
4c7ea9a
rt.wave tests pass against test bl hera.intel
DeniseWorthen Apr 27, 2023
69c8482
all rt.wave baselines past test bl hera.intel,hera.gnu
DeniseWorthen Apr 27, 2023
699ffbe
Merge branch 'feature/add_unstr' of https://github.com/DeniseWorthen/…
DeniseWorthen Apr 27, 2023
a0a3591
rt.wave passes bl on cheyenne.gnu
DeniseWorthen Apr 28, 2023
9d10612
set dnats to 0 in pdlib tests
DeniseWorthen Apr 28, 2023
666912f
Merge branch 'ufs-community:develop' into feature/add_unstr
DeniseWorthen Apr 28, 2023
d558a61
update WW3
DeniseWorthen May 2, 2023
256a4cd
Merge branch 'develop' into feature/add_unstr
DeniseWorthen May 2, 2023
251033b
update rt files, remove testing files
DeniseWorthen May 2, 2023
3f04a0e
bump resources for debug pdlib test
DeniseWorthen May 3, 2023
7a8fabf
update WW3
DeniseWorthen May 4, 2023
c08bd88
Merge remote-tracking branch 'origin/develop' into feature/add_unstr
DeniseWorthen May 4, 2023
535db28
Merge branch 'ufs-community:develop' into feature/add_unstr
DeniseWorthen May 9, 2023
d26db50
Update rt.sh
zach1221 May 9, 2023
5c226fd
remove scotch from ufs_common
DeniseWorthen May 10, 2023
fb9805e
Merge branch 'develop' into feature/add_unstr
DeniseWorthen May 12, 2023
0df329c
add new BL_DATE
jkbk2004 May 13, 2023
0f0a46e
add hera.intel RT log: passed
jkbk2004 May 14, 2023
9287f00
add cheyenne.gnu RT log: passed
jkbk2004 May 14, 2023
db8b884
remove tests on gnu
DeniseWorthen May 14, 2023
9ac0b12
add here.gnu RT log: passed
jkbk2004 May 15, 2023
d420697
add orion.intel RT log: passed
jkbk2004 May 15, 2023
a6c9563
add jet.intel RT log: paased
jkbk2004 May 15, 2023
6c47b61
add gaea.intel RT log: passed
jkbk2004 May 15, 2023
f42be49
add cheyenne.intel RT log: passed
jkbk2004 May 15, 2023
e70465a
WCOSS2 Intel RT Log
BrianCurtis-NOAA May 15, 2023
8192300
Merge branch 'feature/add_unstr' of github.com:DeniseWorthen/ufs-weat…
BrianCurtis-NOAA May 15, 2023
6ec242b
Acorn Intel RT Log
BrianCurtis-NOAA May 15, 2023
5f616ce
update WW3 and revert gitmodules
DeniseWorthen May 15, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -70,6 +70,7 @@ set(OPENMP ON CACHE BOOL "Enable OpenMP threading")
set(PARALLEL_NETCDF OFF CACHE BOOL "Enable parallel NetCDF")
set(JEDI_DRIVER OFF CACHE BOOL "Enable JEDI as top level driver")
set(CMEPS_AOFLUX OFF CACHE BOOL "Enable atmosphere-ocean flux calculation in mediator")
set(PDLIB OFF CACHE BOOL "Enable Domain Decomposition in WW3 via PDLIB")

set(CMAKE_Platform $ENV{CMAKE_Platform})
if(CMAKE_Platform)
Expand Down Expand Up @@ -206,7 +207,11 @@ if(WW3)
set(UFS_CAP "MULTI_ESMF" CACHE STRING "Build with MULTI_ESMF cap")
list(APPEND _ufs_defs_private FRONT_WW3=WMESMFMD)
else()
set(SWITCH "meshcap" CACHE STRING "NUOPC mesh cap")
if(PDLIB)
set(SWITCH "meshcap_pdlib" CACHE STRING "NUOPC mesh cap")
else()
set(SWITCH "meshcap" CACHE STRING "NUOPC mesh cap")
endif()
set(UFS_CAP "NUOPC_MESH" CACHE STRING "Build with NUOPC_MESH cap")
list(APPEND _ufs_defs_private FRONT_WW3=wav_comp_nuopc)
endif()
Expand Down
3 changes: 3 additions & 0 deletions modulefiles/ufs_cheyenne.gnu.lua
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,9 @@ load(pathJoin("hpc-gnu", hpc_gnu_ver))
hpc_mpt_ver=os.getenv("hpc_mpt_ver") or "2.25"
load(pathJoin("hpc-mpt", hpc_mpt_ver))

scotch_ver=os.getenv("scotch_ver") or "7.0.3"
load(pathJoin("scotch", scotch_ver))

load("ufs_common")

setenv("CC", "mpicc")
Expand Down
3 changes: 3 additions & 0 deletions modulefiles/ufs_cheyenne.intel.lua
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,9 @@ load(pathJoin("hpc-intel", hpc_intel_ver))
hpc_mpt_ver=os.getenv("hpc_mpt_ver") or "2.25"
load(pathJoin("hpc-mpt", hpc_mpt_ver))

scotch_ver=os.getenv("scotch_ver") or "7.0.3"
load(pathJoin("scotch", scotch_ver))

load("ufs_common")

setenv("CC", "mpicc")
Expand Down
3 changes: 3 additions & 0 deletions modulefiles/ufs_hera.gnu.lua
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,9 @@ load(pathJoin("hpc-gnu", hpc_gnu_ver))
hpc_mpich_ver=os.getenv("hpc_mpich_ver") or "3.3.2"
load(pathJoin("hpc-mpich", hpc_mpich_ver))

scotch_ver=os.getenv("scotch_ver") or "7.0.3"
load(pathJoin("scotch", scotch_ver))

load("ufs_common")

setenv("CC", "mpicc")
Expand Down
3 changes: 3 additions & 0 deletions modulefiles/ufs_hera.intel.lua
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,9 @@ load(pathJoin("hpc-intel", hpc_intel_ver))
hpc_impi_ver=os.getenv("hpc_impi_ver") or "2022.1.2"
load(pathJoin("hpc-impi", hpc_impi_ver))

scotch_ver=os.getenv("scotch_ver") or "7.0.3"
load(pathJoin("scotch", scotch_ver))

load("ufs_common")

setenv("CC", "mpiicc")
Expand Down
3 changes: 3 additions & 0 deletions modulefiles/ufs_orion.intel.lua
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,9 @@ load(pathJoin("hpc-intel", hpc_intel_ver))
hpc_impi_ver=os.getenv("hpc_impi_ver") or "2022.1.2"
load(pathJoin("hpc-impi", hpc_impi_ver))

scotch_ver=os.getenv("scotch_ver") or "7.0.3"
load(pathJoin("scotch", scotch_ver))

load("ufs_common")

setenv("CC", "mpiicc")
Expand Down
1,352 changes: 676 additions & 676 deletions tests/RegressionTests_acorn.intel.log

Large diffs are not rendered by default.

728 changes: 495 additions & 233 deletions tests/RegressionTests_cheyenne.gnu.log

Large diffs are not rendered by default.

1,372 changes: 686 additions & 686 deletions tests/RegressionTests_cheyenne.intel.log

Large diffs are not rendered by default.

1,366 changes: 684 additions & 682 deletions tests/RegressionTests_gaea.intel.log

Large diffs are not rendered by default.

659 changes: 423 additions & 236 deletions tests/RegressionTests_hera.gnu.log

Large diffs are not rendered by default.

6,114 changes: 2,464 additions & 3,650 deletions tests/RegressionTests_hera.intel.log

Large diffs are not rendered by default.

1,250 changes: 625 additions & 625 deletions tests/RegressionTests_jet.intel.log

Large diffs are not rendered by default.

2,256 changes: 1,259 additions & 997 deletions tests/RegressionTests_orion.intel.log

Large diffs are not rendered by default.

1,158 changes: 579 additions & 579 deletions tests/RegressionTests_wcoss2.intel.log

Large diffs are not rendered by default.

12 changes: 12 additions & 0 deletions tests/default_vars.sh
Original file line number Diff line number Diff line change
Expand Up @@ -73,6 +73,18 @@

INPES_aqm=33; JNPES_aqm=8

THRD_cpl_unstr=1
INPES_cpl_unstr=3; JNPES_cpl_unstr=8; WPG_cpl_unstr=6
OCN_tasks_cpl_unstr=20
ICE_tasks_cpl_unstr=10
WAV_tasks_cpl_unstr=60

THRD_cpl_unstr_mpi=1
INPES_cpl_unstr_mpi=4; JNPES_cpl_unstr_mpi=8; WPG_cpl_unstr_mpi=6
OCN_tasks_cpl_unstr_mpi=34
ICE_tasks_cpl_unstr_mpi=20
WAV_tasks_cpl_unstr_mpi=50

aqm_omp_num_threads=1
atm_omp_num_threads=1
chm_omp_num_threads=1
Expand Down
149 changes: 0 additions & 149 deletions tests/parm/nems.configure.cpld_esmfthreads.IN

This file was deleted.

9 changes: 9 additions & 0 deletions tests/rt.conf
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,15 @@ RUN | cpld_restart_c48
COMPILE | -DAPP=S2SWA -DCCPP_SUITES=FV3_GFS_v17_coupled_p8,FV3_GFS_cpld_rasmgshocnsstnoahmp_ugwp -DFASTER=ON | - cheyenne.intel | fv3 |
RUN | cpld_control_p8_faster | - cheyenne.intel | fv3 |

# Unstructured WW3 mesh
COMPILE | -DAPP=S2SW -DCCPP_SUITES=FV3_GFS_v17_coupled_p8 -DPDLIB=ON | +hera.intel orion.intel cheyenne.intel | fv3 |
RUN | cpld_control_pdlib_p8 | +hera.intel orion.intel cheyenne.intel | fv3 |
RUN | cpld_restart_pdlib_p8 | +hera.intel orion.intel cheyenne.intel | | cpld_control_pdlib_p8
RUN | cpld_mpi_pdlib_p8 | +hera.intel orion.intel cheyenne.intel | | cpld_control_pdlib_p8

COMPILE | -DAPP=S2SW -DCCPP_SUITES=FV3_GFS_v17_coupled_p8 -DPDLIB=ON -DDEBUG=ON | +hera.intel orion.intel cheyenne.intel | fv3 |
RUN | cpld_debug_pdlib_p8 | +hera.intel orion.intel cheyenne.intel | fv3 |

###################################################################################################################################################################################
# ATM tests #
###################################################################################################################################################################################
Expand Down
12 changes: 6 additions & 6 deletions tests/rt.sh
Original file line number Diff line number Diff line change
Expand Up @@ -358,12 +358,12 @@ elif [[ $MACHINE_ID = expanse.* ]]; then
PTMP=$dprefix
SCHEDULER=slurm
cp fv3_conf/fv3_slurm.IN_expanse fv3_conf/fv3_slurm.IN

elif [[ $MACHINE_ID = noaacloud.* ]]; then

module use /apps/modules/modulefiles
module load rocoto/1.3.3

ROCOTORUN=$(which rocotorun)
ROCOTOSTAT=$(which rocotostat)
ROCOTOCOMPLETE=$(which rocotocomplete)
Expand All @@ -379,8 +379,8 @@ elif [[ $MACHINE_ID = expanse.* ]]; then
SCHEDULER=slurm
cp fv3_conf/fv3_slurm.IN_noaacloud fv3_conf/fv3_slurm.IN
cp fv3_conf/compile_slurm.IN_noaacloud fv3_conf/compile_slurm.IN


else
die "Unknown machine ID, please edit detect_machine.sh file"
fi
Expand Down Expand Up @@ -468,7 +468,7 @@ if [[ $TESTS_FILE =~ '35d' ]] || [[ $TESTS_FILE =~ 'weekly' ]]; then
fi


BL_DATE=20230510
BL_DATE=20230512

RTPWD=${RTPWD:-$DISKNM/NEMSfv3gfs/develop-${BL_DATE}/${RT_COMPILER^^}}

Expand Down
19 changes: 13 additions & 6 deletions tests/rt_gnu.conf
Original file line number Diff line number Diff line change
Expand Up @@ -95,14 +95,21 @@ RUN | rap_control_dyn64_phy32_debug
# S2S tests #
##################################################################################################################################################################

COMPILE | -DAPP=S2SWA -DCCPP_SUITES=FV3_GFS_v17_coupled_p8,FV3_GFS_cpld_rasmgshocnsstnoahmp_ugwp | | fv3 |
RUN | cpld_control_p8 | | fv3 |
COMPILE | -DAPP=S2SWA -DCCPP_SUITES=FV3_GFS_v17_coupled_p8,FV3_GFS_cpld_rasmgshocnsstnoahmp_ugwp | | fv3 |
RUN | cpld_control_p8 | | fv3 |

COMPILE | -DAPP=S2S -DCCPP_SUITES=FV3_GFS_v17_coupled_p8,FV3_GFS_cpld_rasmgshocnsstnoahmp_ugwp | | fv3 |
RUN | cpld_control_nowave_noaero_p8 | | fv3 |
COMPILE | -DAPP=S2S -DCCPP_SUITES=FV3_GFS_v17_coupled_p8,FV3_GFS_cpld_rasmgshocnsstnoahmp_ugwp | | fv3 |
RUN | cpld_control_nowave_noaero_p8 | | fv3 |

COMPILE | -DAPP=S2SWA -DDEBUG=ON -DCCPP_SUITES=FV3_GFS_v17_coupled_p8,FV3_GFS_cpld_rasmgshocnsstnoahmp_ugwp | | fv3 |
RUN | cpld_debug_p8 | | fv3 |
COMPILE | -DAPP=S2SWA -DDEBUG=ON -DCCPP_SUITES=FV3_GFS_v17_coupled_p8,FV3_GFS_cpld_rasmgshocnsstnoahmp_ugwp | | fv3 |
RUN | cpld_debug_p8 | | fv3 |

# Unstructured WW3
COMPILE | -DAPP=S2SW -DCCPP_SUITES=FV3_GFS_v17_coupled_p8 -DPDLIB=ON | | fv3 |
RUN | cpld_control_pdlib_p8 | | fv3 |

COMPILE | -DAPP=S2SW -DCCPP_SUITES=FV3_GFS_v17_coupled_p8 -DPDLIB=ON -DDEBUG=ON | | fv3 |
RUN | cpld_debug_pdlib_p8 | | fv3 |

##################################################################################################################################################################
# CDEPS Data Atmosphere test #
Expand Down
2 changes: 1 addition & 1 deletion tests/tests/cpld_bmark_p8
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ export LIST_FILES="sfcf006.nc \
export_fv3
export_cpl

export NEMS_CONFIGURE=nems.configure.cpld_esmfthreads.IN
export NEMS_CONFIGURE=nems.configure.cpld.IN

export SYEAR=2013
export SMONTH=04
Expand Down
Loading