Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UW-553 JSON Schema for JEDI driver #462

Merged
merged 9 commits into from
Apr 18, 2024
Merged

UW-553 JSON Schema for JEDI driver #462

merged 9 commits into from
Apr 18, 2024

Conversation

maddenp-noaa
Copy link
Contributor

@maddenp-noaa maddenp-noaa commented Apr 18, 2024 •
edited
Loading

Synopsis

Add JSON Schema support for JEDI driver.

Type

  • Enhancement (adds a new functionality)

Impact

  • This is a non-breaking change (existing functionality continues to work as expected)

Checklist

  • I have added myself and any co-authors to the PR's Assignees list.
  • I have reviewed the documentation and have made any updates necessitated by this change.

@maddenp-noaa maddenp-noaa self-assigned this Apr 18, 2024
maddenp-noaa
maddenp-noaa commented Apr 18, 2024
View reviewed changes
Makefile Show resolved Hide resolved
docs/sections/user_guide/yaml/components/chgres_cube.rst Show resolved Hide resolved
docs/sections/user_guide/yaml/components/fv3.rst Show resolved Hide resolved
docs/shared/chgres_cube.yaml Show resolved Hide resolved
docs/shared/chgres_cube.yaml Show resolved Hide resolved
src/uwtools/drivers/jedi.py Show resolved Hide resolved
@maddenp-noaa maddenp-noaa marked this pull request as ready for review April 18, 2024 18:01
christinaholtNOAA
christinaholtNOAA approved these changes Apr 18, 2024
View reviewed changes
Copy link
Contributor

@christinaholtNOAA christinaholtNOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

docs/shared/chgres_cube.yaml Show resolved Hide resolved
NaureenBharwaniNOAA
NaureenBharwaniNOAA approved these changes Apr 18, 2024
View reviewed changes
Copy link
Contributor

@NaureenBharwaniNOAA NaureenBharwaniNOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

elcarpenterNOAA
elcarpenterNOAA approved these changes Apr 18, 2024
View reviewed changes
Copy link
Contributor

@elcarpenterNOAA elcarpenterNOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@maddenp-noaa maddenp-noaa merged commit be67fb2 into ufs-community:main Apr 18, 2024
2 checks passed
@maddenp-noaa maddenp-noaa deleted the UW-553 branch April 18, 2024 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elcarpenterNOAA elcarpenterNOAA elcarpenterNOAA approved these changes

@NaureenBharwaniNOAA NaureenBharwaniNOAA NaureenBharwaniNOAA approved these changes

@christinaholtNOAA christinaholtNOAA christinaholtNOAA approved these changes

@fgabelmannjr fgabelmannjr Awaiting requested review from fgabelmannjr fgabelmannjr is a code owner

@WeirAE WeirAE Awaiting requested review from WeirAE WeirAE is a code owner

Assignees

@maddenp-noaa maddenp-noaa

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@maddenp-noaa @christinaholtNOAA @NaureenBharwaniNOAA @elcarpenterNOAA