-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UW-586: Build driver for WaveWatchIII #496
Conversation
cycle subclassing still has issues
At least for the coupled application, ww3 also requires a directory named restart_wave in the run directory. I'm not sure if that is always true, but if so it should be part of provisioning the run directory. |
@benjamin-cash Thank you! I hadn't seen that in the documentation, so I may have to rely on your hands-on experience to keep me honest here! |
tests need work
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I took a second look at the code surrounding the new driver and provided a few comments. I didn't look at any of the tests in detail at this point.
@WeirAE I think this looks nice as far as pulling out a base class/subclass for the driver and stand-alone driver. I'm concerned a bit about the wording and getting the relationships right on how we name these classes. I think this kind of activity is closely related to discussions we've had regarding clean code, so I'm going to trigger some semantics questions in offline conversations. |
directory test still failing pending driver naming decisions
It seems to be missing the API and CLI documentation. Is that coming later, or in a separate PR? |
@elcarpenterNOAA This one has been limited to just the coupled library mode, which should be fully disconnected from the API and CLI. Though it might be worth still putting something in place to cover it? |
Co-authored-by: Paul Madden <136389411+maddenp-noaa@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are still a few things here that I'd like to see corrected.
Unresolved a few prior threads for ease of further discussion |
documentation updated test currently failing, in progress
Co-authored-by: Paul Madden <136389411+maddenp-noaa@users.noreply.github.com>
Co-authored-by: Paul Madden <136389411+maddenp-noaa@users.noreply.github.com>
Co-authored-by: Paul Madden <136389411+maddenp-noaa@users.noreply.github.com>
Co-authored-by: Paul Madden <136389411+maddenp-noaa@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still just one more thing below, but this is looking good otherwise.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Synopsis
Build driver for WaveWatchIII. As per discussion, scope is limited to "library" version for the coupled model. This also requires splitting the base
Driver()
methods and should not expose this driver to the CLI or API.AC:
new driver introduced in CLI and API
JSON Schema validation capability
Documentation for CLI, API and landing page addition
Type
Impact
Checklist