Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test Concurrency #504

Merged
merged 6 commits into from
Jun 5, 2024

Conversation

maddenp-noaa
Copy link
Contributor

Synopsis

Add concurrency to lint and unittest test targets.

Previous times:

  • make lint 0m8.276s
  • make unittest 0m17.299s
  • make test 0m25.268s

New times:

  • make lint 0m4.315s
  • make unittest 0m6.267s
  • make test 0m11.054s

I also updated several test- and run-time packages to their latest versions.

NOTE After this merges and you pull the changes into your fork, you'll need to re-create your devshell. Exit your existing shell, run make clean-devenv to remove the old one, optionally run conda clean --all --yes to clean up old packages and reclaim some disk space, then run make devshell to create a new devshell with the updated packages.

Type

  • Code maintenance (refactoring, etc. without behavior change)
  • Tooling (CI, code-quality, packaging, revision-control, etc.)

Impact

  • This is a non-breaking change (existing functionality continues to work as expected)

Checklist

  • I have added myself and any co-authors to the PR's Assignees list.
  • I have reviewed the documentation and have made any updates necessitated by this change.

Copy link
Contributor

@elcarpenterNOAA elcarpenterNOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've never been more thrilled to see a PR in my life.

Copy link
Contributor

@christinaholtNOAA christinaholtNOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look GREAT to me!

@maddenp-noaa maddenp-noaa merged commit 737675c into ufs-community:main Jun 5, 2024
2 checks passed
@maddenp-noaa maddenp-noaa deleted the unit-test-concurrency branch June 5, 2024 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants