Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disambiguate threads #539

Merged
merged 13 commits into from
Jul 24, 2024
Merged

Disambiguate threads #539

merged 13 commits into from
Jul 24, 2024

Conversation

maddenp-noaa
Copy link
Contributor

@maddenp-noaa maddenp-noaa commented Jul 22, 2024 •
edited
Loading

Synopsis

Disambiguate the UW YAML threads item by arranging for it to be specified just once.

Type

  • Code maintenance (refactoring, etc. without behavior change)
  • Documentation

Impact

  • This is a non-breaking change (existing functionality continues to work as expected)

Checklist

  • I have added myself and any co-authors to the PR's Assignees list.
  • I have reviewed the documentation and have made any updates necessitated by this change.

@maddenp-noaa maddenp-noaa self-assigned this Jul 22, 2024
maddenp-noaa
maddenp-noaa commented Jul 22, 2024
View reviewed changes
docs/sections/user_guide/yaml/execution.rst Outdated Show resolved Hide resolved
docs/sections/user_guide/yaml/execution.rst Outdated Show resolved Hide resolved
src/uwtools/drivers/driver.py Show resolved Hide resolved
src/uwtools/drivers/driver.py Show resolved Hide resolved
src/uwtools/drivers/driver.py Show resolved Hide resolved
src/uwtools/resources/jsonschema/execution.jsonschema Show resolved Hide resolved
src/uwtools/resources/jsonschema/execution.jsonschema Show resolved Hide resolved
@maddenp-noaa maddenp-noaa marked this pull request as ready for review July 24, 2024 02:42
elcarpenterNOAA
elcarpenterNOAA approved these changes Jul 24, 2024
View reviewed changes
Copy link
Contributor

@elcarpenterNOAA elcarpenterNOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@maddenp-noaa maddenp-noaa merged commit 01ad420 into ufs-community:main Jul 24, 2024
2 checks passed
@maddenp-noaa maddenp-noaa deleted the disambiguate-threads branch July 24, 2024 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elcarpenterNOAA elcarpenterNOAA elcarpenterNOAA approved these changes

@NaureenBharwaniNOAA NaureenBharwaniNOAA NaureenBharwaniNOAA approved these changes

@christinaholtNOAA christinaholtNOAA christinaholtNOAA approved these changes

@fgabelmannjr fgabelmannjr Awaiting requested review from fgabelmannjr fgabelmannjr is a code owner

@WeirAE WeirAE Awaiting requested review from WeirAE WeirAE is a code owner

Assignees

@maddenp-noaa maddenp-noaa

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@maddenp-noaa @christinaholtNOAA @NaureenBharwaniNOAA @elcarpenterNOAA