[PL/HT] Fix computation of darcy velocity. #2124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
endJunction
approved these changes
May 16, 2018
wenqing
approved these changes
May 16, 2018
|
Since the HT process is not tested for some time and the current results differ from the expected values I'll add more ctest to ensure the process will compute correct results. @wenqing Is your PR for the staggered scheme handling the Darcy velocity? Then maybe we can merge our works? |
|
@TomFischer Yes, it is. My PR is for the staggered scheme handling the Darcy velocity. Therefore, my PR should not have the same changes as that in this PR. Should I re-sent this PR to your branch for this PR? |
|
@wenqing I think we can let them as separate PRs. |
Corrected access to the local pressure and temperature variables.
TomFischer
force-pushed
the
HTFixDarcyVelocity
branch
from
be93c68
to
c9e1b43
Compare
TomFischer
force-pushed
the
HTFixDarcyVelocity
branch
from
c9e1b43
to
953a02a
Compare
Also relax the tolerance for temperature in the test.
|
OpenGeoSys development has been moved to GitLab. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Corrected access to the local pressure and temperature variables.
Fixes issue #2054.