Fixed the calculation of the Darcy velocity in staggered TH #2127
Conversation
ProcessLib/HT/HTProcess.cpp
Outdated
| @@ -140,8 +143,8 @@ void HTProcess::assembleWithJacobianConcreteProcess( | |||
| // Call global assembler for each local assembly item. | |||
| GlobalExecutor::executeMemberDereferenced( | |||
| _global_assembler, &VectorMatrixAssembler::assembleWithJacobian, | |||
| _local_assemblers, dof_tables, t, x, xdot, dxdot_dx, | |||
| dx_dx, M, K, b, Jac, _coupled_solutions); | |||
| _local_assemblers, dof_tables, t, x, xdot, dxdot_dx, dx_dx, M, K, b, | |||
There was a problem hiding this comment.
Changes due to clang-format
ProcessLib/HT/HTProcess.cpp
Outdated
| @@ -181,7 +184,7 @@ void HTProcess::setCoupledTermForTheStaggeredSchemeToLocalAssemblers() | |||
| } | |||
|
|
|||
| std::tuple<NumLib::LocalToGlobalIndexMap*, bool> | |||
| HTProcess::getDOFTableForExtrapolatorData() const | |||
| HTProcess::getDOFTableForExtrapolatorData() const | |||
There was a problem hiding this comment.
Change due to clang-format
ProcessLib/HT/HTProcess.cpp
Outdated
| std::move(all_mesh_subsets_single_component), | ||
| // by location order is needed for output | ||
| NumLib::ComponentOrder::BY_LOCATION), manage_storage); | ||
| std::move(all_mesh_subsets_single_component), |
There was a problem hiding this comment.
Change due to clang-format
| local_M.noalias() += w * (porosity * dfluid_density_dp / fluid_density + | ||
| specific_storage) * | ||
| N.transpose() * N; | ||
| local_M.noalias() += |
There was a problem hiding this comment.
Change due to clang-format
|
@TomFischer I will add that benchmark |
|
@chleh That benchmark, which sounds like a sensitive analysis, gets slightly difference between the reference result and the result by the present master branch by using either the monolithic scheme or the staggered scheme. Since that benchmark is marked as LARGE, it is not checked on jenkins. For which change in the code for the slight discrepancy on results is still under investigating . The other benchmarks are OK. |
processes of HT in the local assembly.
…tepping of a HT test
|
OpenGeoSys development has been moved to GitLab. |
Follow up PR #2124, this PR fixes a bug in the calculation of the Darcy velocity in the staggered TH. The bug is caused by passing wrong parameters to the arguments of the velocity calculation function.
To fix the bug and also make the source code more readable, process indices are introduced in the local assembler of the staggered scheme for HT.
Due to the partitioning of nodal/element properties being available now, the number of parallel compute cores for the two related benchmarks are increased to three from one.