Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Rogue] Remove time field from publication forms, keep information around. #1058

Closed
1 of 5 tasks
mietcls opened this issue Apr 11, 2023 · 16 comments · Fixed by #1071
Closed
1 of 5 tasks

[Rogue] Remove time field from publication forms, keep information around. #1058

mietcls opened this issue Apr 11, 2023 · 16 comments · Fixed by #1071
Assignees
Labels
enhancement New feature or request

Comments

@mietcls
Copy link
Member

mietcls commented Apr 11, 2023

Improvement

Remove time field from publication forms, keep information around.

For dissertations, we ask for the Time of defense:
Scherm­afbeelding 2023-04-11 om 13 50 55
Scherm­afbeelding 2023-04-11 om 14 08 28

When I asked around who uses this information; nobody could answer me.
People often do not know when it happened or fail to find that information, and since it is a required field people just fill out something.

Example: https://backoffice.biblio.ugent.be/publication/01GX7YWD4DCT65Q80Z23761P66?redirect-url=%2Fpublication%3Fq%3D%26f%255Btype%255D%3Ddissertation

Expected behaviour

When this ticket is done

  • Nobody needs fill out this field – it is not required any longer.
  • Nobody needs to see this field.
  • The historic information is kept around, but it is hidden.
  • [TBD] we keep the infrastructure around for one year, if nobody complains, we throw it all out.
  • The information is not shown in our front-office.

Please comment if I did not foresee specific problems.

Next year

  • If nobody complained before 01/04/2024, we remove this joke completely.

Who to blame if anyone asks

Send them to @mietcls

@mietcls mietcls changed the title Go Rogue: remove time field from publication forms, keep information around. [Rogue] Remove time field from publication forms, keep information around. Apr 11, 2023
@mietcls mietcls added the enhancement New feature or request label Apr 11, 2023
@mietcls mietcls moved this to Ready to build 🚀🤓 in Biblio overview Apr 11, 2023
@mietcls mietcls modified the milestone: Q2 Apr 12, 2023
@nicolasfranck nicolasfranck self-assigned this Apr 17, 2023
@nicolasfranck
Copy link
Contributor

nicolasfranck commented Apr 17, 2023

@mietcls but is visible in the frontend:

e.g. https://biblio.ugent.be/publication/8551640

see left column and look for 2018-03-02 15:00

@nics the defense time is embedded within field defense.date of the biblio frontend index
Removing this either requires to reindex all publication data or to split off the time section
in the view. That last option is probably not wanted, as a change to a field like defense.date would
trigger an update of all the timestamps for those publications, which may be a lot.

@mietcls
Copy link
Member Author

mietcls commented Apr 17, 2023

@nicolasfranck okay, what if we hide it for now (not delete it yet)? Slowly remove this information, without triggering too much work or drawing too much attention?

@mietcls
Copy link
Member Author

mietcls commented Apr 17, 2023

The plot thickens: in September 2018 this has been added according to Nicolas F. The issue does not state why it was added.

@nicolasfranck
Copy link
Contributor

If we hide it in the backoffice, we have to hide it in the frontend too.

Safest option would be to split off the time section in the view.
Ugly, but visible.

@nicolasfranck
Copy link
Contributor

@mietcls I see the defense date also used here:

  • publication csv export
  • BOF export (docx)
  • mods xml (OAI)

The only external party here is BOF, so maybe that is the source of this field?

@mietcls
Copy link
Member Author

mietcls commented Apr 18, 2023

Great background, I will figure it out @nicolasfranck

@mietcls
Copy link
Member Author

mietcls commented Apr 18, 2023

@nicolasfranck how is this information used, can you see that? Because Anniek and Marthe are unsure whether this is used actively by BOF or just sent.

@mietcls
Copy link
Member Author

mietcls commented Apr 19, 2023

Ask Inge and Dries perhaps a researcher

@mietcls
Copy link
Member Author

mietcls commented Apr 19, 2023

Good news from the BOF side. Our colleague asked around at BOF:

Wat BOF betreft, schrappen die handel. Wij hebben hier nog nooit gebruik van gemaakt en ik zie ook niet meteen relevantie voor anderen.

The head of research coordination also confirms:

Het uur mag inderdaad geschrapt worden. De datum is het enige belangrijke.

Will do a last check with Dries.

@mietcls
Copy link
Member Author

mietcls commented Apr 19, 2023

Dries also confirms it can go, does not remember why it was introduced in 2018.

@nics
Copy link
Member

nics commented Apr 20, 2023

[TBD] we keep the infrastructure around for one year, if nobody complains, we throw it all out.

@mietcls the code will have bitrotted by then and stuff like that pollutes the codebase, better to just delete it. We can always get it out of the git history if necessary.

@mietcls
Copy link
Member Author

mietcls commented Apr 20, 2023

@nics and the data?

@nics
Copy link
Member

nics commented Apr 20, 2023

@mietcls also remove? it's still in the audit history

@github-project-automation github-project-automation bot moved this from Ready to build 🚀🤓 to 🧪 To test in Biblio overview Apr 25, 2023
@mietcls
Copy link
Member Author

mietcls commented May 4, 2023

@nicolasfranck did we already resolve the time issue in the front-office? I can't see it yet. Should I create a separate issue?

@nics
Copy link
Member

nics commented May 4, 2023

@mietcls in the end we decided to keep the existing data around for a while as a hidden, deprecated attribute
we can remove it later

@mietcls mietcls moved this from 🧪 To test to Done 🪅 in Biblio overview May 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants