Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Percentage progress on remaining #11

Merged
merged 3 commits into from
Dec 31, 2020
Merged

Percentage progress on remaining #11

merged 3 commits into from
Dec 31, 2020

Conversation

sha1sum
Copy link
Contributor

@sha1sum sha1sum commented Dec 31, 2020

This shows the percentage of the zones that have progressed into the new year on the remaining trigger.

@the-maldridge
Copy link

looks decent, but you have as many lines of diff as you do commits. Consider squashing?

@sha1sum
Copy link
Contributor Author

sha1sum commented Dec 31, 2020

@the-maldridge I usually use the "squash and merge" when merging PR's in GitHub. Would you still prefer me to do it on my side, though?

@the-maldridge
Copy link

I'm neither a maintainer nor owner in this repo, just clicked your link from IRC and figured I'd provide unsolicited review feedback.

@ugjka ugjka merged commit ca84fba into ugjka:master Dec 31, 2020
@ugjka
Copy link
Owner

ugjka commented Dec 31, 2020

The code needed some tweaking, please do git pull if want the latest stuff

ugjka pushed a commit that referenced this pull request Dec 31, 2022
Bumps [github/codeql-action](https://github.com/github/codeql-action) from 1 to 2.
- [Release notes](https://github.com/github/codeql-action/releases)
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md)
- [Commits](github/codeql-action@v1...v2)

---
updated-dependencies:
- dependency-name: github/codeql-action
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants