Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support getters/setters of ES5 #2

Closed
uhop opened this issue Dec 30, 2012 · 4 comments
Closed

Support getters/setters of ES5 #2

uhop opened this issue Dec 30, 2012 · 4 comments
Assignees
Milestone

Comments

@uhop
Copy link
Owner

uhop commented Dec 30, 2012

Add supercalls and advices for getters and setters of ES5. Evaluate, if it should go in a separate module, or included in existing ones (most likely mini.js).

@ghost ghost assigned uhop Dec 30, 2012
@uhop
Copy link
Owner Author

uhop commented Sep 14, 2013

Commit 0fa5a4c switched to a pre-requisite functional marker for advices. Now we can implement them for getters and setters.

@clubajax
Copy link

Do you have docs on how to do getters and setters? I tried this, and it didn't work. It appears to me that DCL overwrites them with standard properties.

dcl(BaseClass, {
get x(){
console.log('getting x does not fire');
...
},
set x (_x){
console.log('setting x does not fire');
...
}
});

@uhop
Copy link
Owner Author

uhop commented Jan 28, 2014

I think you are right. I'll speed up the delivery of this ticket, which will handle such things correctly.

@uhop uhop added the ready label May 1, 2015
@uhop uhop modified the milestones: 2.0, 1.2 Jun 10, 2017
@uhop
Copy link
Owner Author

uhop commented Jun 10, 2017

Addressed in 2.0.

@uhop uhop closed this as completed Jun 10, 2017
@uhop uhop removed the ready label Jun 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants