Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace hasOwnProperty() with a more cumbersome construct. #23

Closed
uhop opened this issue Jun 11, 2017 · 0 comments
Closed

Replace hasOwnProperty() with a more cumbersome construct. #23

uhop opened this issue Jun 11, 2017 · 0 comments
Assignees
@uhop
Labels
enhancement
Milestone
Future

Comments

@uhop
Copy link
Owner

uhop commented Jun 11, 2017

Apparently it is recommended to replace obj.hasOwnProperty(name) with a more cumbersome equivalent:

Object.prototype.hasOwnProperty.call(obj, name)

It prevents potential shadowing of hasOwnProperty().

This method is used by dcl extensively, and it should be evaluated, if some uses should be converted.
@uhop uhop added this to the Future milestone Jun 11, 2017
@uhop uhop self-assigned this Jun 11, 2017
@uhop uhop closed this as completed in 374bd9a Jul 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@uhop uhop

Labels
enhancement
Projects
None yet
Milestone
Future
Development

No branches or pull requests
1 participant
@uhop