Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

midnightSort bug fix #34

Merged
merged 2 commits into from
Jan 18, 2017
Merged

midnightSort bug fix #34

merged 2 commits into from
Jan 18, 2017

Conversation

Sunev
Copy link
Contributor

@Sunev Sunev commented Jan 17, 2017

  1. gather midnightSort from all jobs
  2. sort list of midnightSort, and make sure every element is unique.
  3. apply pl.midnight(game,midnightSort),if @midnightSort is not equal to midnightSort, this job would be skipped.

@Sunev
midnightSort bug fix
6adf92f
@Sunev
block some .midnight()
1db2333 
most @main.midnight()/@sub.midnight() of Complex players is called by invalid midnightSort now. Prevent these calls, in case of missing ```if midnightSort != @midnightSort then return``` in any .midnight()
@Sunev
Copy link
Contributor Author

Sunev commented Jan 18, 2017 •
edited
Loading

most @main.midnight()/@sub.midnight() of Complex players is called by invalid midnightSort now, like call Guard by 100. 1db2333 prevents potential duplicate calls caused by missing if midnightSort != @midnightSort then return in some .midnight()

@Sunev
Copy link
Contributor Author

Sunev commented Jan 18, 2017

It seems that .deadnight() is missed in class Complex, I had it added at 6adf92f.

@uhyo
Copy link
Owner

uhyo commented Jan 18, 2017

Seems good.
I'm as thankful to you as I wish to acknowledge it in my senior thesis.

@uhyo uhyo merged commit 89e8e7d into uhyo:master Jan 18, 2017
@Sunev Sunev deleted the midnightSortFix branch January 18, 2017 11:23
@Sunev Sunev mentioned this pull request Jan 18, 2017
Closed
@Sunev Sunev restored the midnightSortFix branch January 18, 2017 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Sunev @uhyo