Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Converting circular structure to JSON error in Transition.toString #75

Closed
AnWeber opened this issue Aug 24, 2017 · 1 comment
Closed

Converting circular structure to JSON error in Transition.toString #75

AnWeber opened this issue Aug 24, 2017 · 1 comment
Labels
bug
Milestone
5.0.7

Comments

@AnWeber
Copy link

AnWeber commented Aug 24, 2017 •
edited
Loading

If $trace.enable('Transition') is called and one Transition Parameter is a circular structure, then a Converting circular structure to JSON error is triggered.

The error happens in transition.ts - toString Line 759

AngularJS: 1.6.5
UI Router: v1.0.6
DEMO: http://plnkr.co/edit/yzJ1cV0DU1izGUFxZM1C?p=preview
@AnWeber AnWeber changed the title Maximum call stack size exceeded in Transition.toString with circular structure Converting circular structure to JSON error in Transition.toString Aug 24, 2017
@christopherthielen christopherthielen added this to the 5.0.7 milestone Sep 16, 2017
@AnWeber
Copy link
Author

AnWeber commented Sep 21, 2017

Thanks for your fix. Great Work. Maybe you also fixed angular-ui/ui-router#3521 with this commit. I am waiting for a new angularjs release to test this issue.

wawyed pushed a commit to wawyed/core that referenced this issue Mar 3, 2018
@christopherthielen @wawyed
fix(trace): Support tracing of object-parameters with circular refere…
9cd9d66 
…nces

Closes ui-router#75
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
5.0.7
Development

No branches or pull requests
2 participants
@christopherthielen @AnWeber