Skip to content

fixes to support React.StrictMode #512

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 4, 2019
Merged

fixes to support React.StrictMode #512

merged 2 commits into from
Sep 4, 2019

Conversation

wallzero
Copy link
Contributor

@wallzero wallzero commented Sep 4, 2019

resolves issue #463
repeat of PR #499

In anticipation for React suspense and concurrent mode, it is advisable to test with <React.StrictMode> and resolve any issues.

  • Wrap example in <React.StrictMode>
  • Switch componentWillMount to componentDidMount
  • Switch UIRouter component constructor to componentDidMount
  • fix minor build and test issues

@christopherthielen christopherthielen merged commit cd8777a into ui-router:master Sep 4, 2019
@wallzero wallzero mentioned this pull request Sep 12, 2019
Closed
@kirstenOtting
Copy link

Thanks for these fixes!This resolves console warnings in React 16.9
@christopherthielen any chance a release can be cut including this soon?

@christopherthielen
Copy link
Member

@shadesofkae https://github.com/ui-router/react/releases/tag/0.8.10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@wallzero @kirstenOtting @christopherthielen @schlesiger