This repository has been archived by the owner on Oct 13, 2024. It is now read-only.
Introduce AUTO as a valid source language #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uinput
suggested changes
Aug 5, 2018
deeplator/translator.py
Outdated
| @@ -3,7 +3,8 @@ | |||
| from .jsonrpc import JSONRPCBuilder | |||
|
|
|||
| POST_URL = "https://www2.deepl.com/jsonrpc" | |||
| VALID_LANGS = ["EN", "DE", "FR", "ES", "IT", "NL", "PL"] | |||
| SOURCE_LANGS = ["AUTO", "EN", "DE", "FR", "ES", "IT", "NL", "PL"] | |||
There was a problem hiding this comment.
I'd like the language codes to be index independent for better readability. I think for now it's sufficient to define a AUTO_LANG = "AUTO" and set SOURCE_LANGS = TARGET_LANGS + [AUTO_LANG].
deeplator/translator.py
Outdated
| @@ -3,7 +3,8 @@ | |||
| from .jsonrpc import JSONRPCBuilder | |||
|
|
|||
| POST_URL = "https://www2.deepl.com/jsonrpc" | |||
| VALID_LANGS = ["EN", "DE", "FR", "ES", "IT", "NL", "PL"] | |||
| SOURCE_LANGS = ["AUTO", "EN", "DE", "FR", "ES", "IT", "NL", "PL"] | |||
| TARGET_LANGS = SOURCE_LANGS[1:] | |||
There was a problem hiding this comment.
TARGET_LANGS can be defined like the old VALID_LANGS then.
deeplator/translator.py
Outdated
| } | ||
| if self.src_lang != SOURCE_LANGS[0]: |
There was a problem hiding this comment.
Here we can use AUTO_LANG instead to get rid of the index.
deeplator/translator.py
Outdated
| "target_lang": self.dst_lang | ||
| } | ||
| } | ||
| if self.src_lang != SOURCE_LANGS[0]: |
There was a problem hiding this comment.
Here we should use AUTO_LANG, too.
|
It should be fixed now. |
uinput
approved these changes
Aug 5, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is my own take at fixing #2.