-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
2d shape #54
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since the code-coverage doesn't seem to work, have you made sure no new tests are needed for your new changes?
blobmodel/model.py
Outdated
), | ||
) | ||
return start, stop | ||
return 0, self._geometry.t.size |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is equivalent to the blob.v_x==0
case. We could reduce a level of indentation by writing:
if blob_v_x == 0 or not speed_up:
return 0, self._geometry.t_size
speed_up code
what do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indeed, good one!
f"{self.__class__.__name__}.blob_shape not implemented" | ||
) | ||
theta_x = x_diffs / self.width_prop | ||
return self.blob_shape.get_pulse_shape_prop(theta_x, ...) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
... serves as a placeholder for kwargs
right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yep
Ok, once the test pass I think it's ready to be merged |
#53