-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Large patterns #298
Large patterns #298
Conversation
331dc84
to
efefbb6
Compare
Changes Unknown when pulling ad68083 on large-patterns into * on master*. |
Changes Unknown when pulling 0278f80 on large-patterns into * on master*. |
This version (a0166ac) is unfortunately worse than the current master:
|
With aa0becd the code is now more efficient (only a 4% slowdown vs. 16%) and I will run some benchmarks again. |
This means that when we add or a remove a crate in the future only that one line will show up in the diff.
This reverts commit 301e3d4b9709a1bf946258de8caec9f4b23c42a8.
Finally found a somewhat working version. This branch now wins against the current master with |
Implements #231. Will use the large patterns from Michi/Pachi. It's still work in progress. It will have a lot of overlap with the small patterns. But for now I will just keep those two completely separate. In a next PR I will see if I can clean this up and DRY this up a bit.