Remove plays again #321
Merged
Remove plays again #321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
plays was very similar to playouts. It just included a scaling factor to nudge the bot towards trying to produce wins that have a larger margin. That obviously didn't work so I think it makes sense to throw it out as it's just added complexity for no gain. I also removed the `Node#mark_as_terminal` function because I couldn't figure out what it's purpose was. We'll have to wait for the benchmark results to see if I messed up. ;)
|
The results are in, and it's either the same or even slightly better than before:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
playswas very similar toplayouts. It just included a scaling factor to nudge the bot towards trying to produce wins that have a larger margin. That obviously didn't work so I think it makes sense to throw it out as it's just added complexity for no gain.I also removed the
Node#mark_as_terminalfunction because I couldn't figure out what it's purpose was. We'll have to wait for the benchmark results to see if I messed up. ;)