Skip to content
This repository has been archived by the owner on May 14, 2024. It is now read-only.

Feature/delete file in s3 refactor #29 #45

Merged
merged 14 commits into from
Nov 12, 2018

Conversation

oliver-tarrant-tessella
Copy link
Collaborator

Refactoring of the external data services, creating a minio storage adapter between s3 interface and external data storage with unit tests for external data services

To test:

  • Run unit tests

#29

Copy link
Collaborator

@robert-clegg-tessella robert-clegg-tessella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please tidy up the new tests and try to work out how to parameterise tests inside a class. I'll push changes to str2bool_test.py to show you how it's done outside a class.

configuration.s3_access_key,
configuration.s3_secret_key,
configuration.s3_use_secure)
self._s3_client = MinioAdapter(configuration)
self._bucket_standard = configuration.bucket_standard
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whenever you add something to the configuration, you need to also add it to example_configuration.ini (and maybe also update the wiki)

# Create mock buckets
self.mock_bucket_1 = mock.create_autospec(Bucket)
self.mock_bucket_2 = mock.create_autospec(Bucket)
self.mock_bucket_1.name = "Bucket_1"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this bucket name be invalid?

@oliver-tarrant-tessella oliver-tarrant-tessella merged commit 62ce248 into master Nov 12, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants