This repository has been archived by the owner on May 14, 2024. It is now read-only.
Feature/delete file in s3 refactor #29 #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliver-tarrant-tessella
requested review from
robert-clegg-tessella and
ray-millward-tessella
robert-clegg-tessella
suggested changes
Nov 12, 2018
ditto_web_api/DittoWebApi/tests/services/external_data_services_test.py
Outdated
Show resolved
Hide resolved
ditto_web_api/DittoWebApi/tests/services/external_data_services_test.py
Outdated
Show resolved
Hide resolved
ditto_web_api/DittoWebApi/tests/services/external_data_services_test.py
Outdated
Show resolved
Hide resolved
ditto_web_api/DittoWebApi/tests/services/external_data_services_test.py
Outdated
Show resolved
Hide resolved
robert-clegg-tessella
suggested changes
Nov 12, 2018
ditto_web_api/DittoWebApi/src/services/external/external_data_service.py
Outdated
Show resolved
Hide resolved
| configuration.s3_access_key, | ||
| configuration.s3_secret_key, | ||
| configuration.s3_use_secure) | ||
| self._s3_client = MinioAdapter(configuration) | ||
| self._bucket_standard = configuration.bucket_standard |
There was a problem hiding this comment.
Whenever you add something to the configuration, you need to also add it to example_configuration.ini (and maybe also update the wiki)
| # Create mock buckets | ||
| self.mock_bucket_1 = mock.create_autospec(Bucket) | ||
| self.mock_bucket_2 = mock.create_autospec(Bucket) | ||
| self.mock_bucket_1.name = "Bucket_1" |
There was a problem hiding this comment.
Shouldn't this bucket name be invalid?
robert-clegg-tessella
approved these changes
Nov 12, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactoring of the external data services, creating a minio storage adapter between s3 interface and external data storage with unit tests for external data services
To test:
#29