BUG: vertical displacement not taken into account in compute_x_points() method

[RemDelaporteMathurin]

paramak/paramak/parametric_components/tokamak_plasma.py

Lines 181 to 191 in ba9eeae

	lower_x_point = (
	1-(1+shift)*triangularity*minor_radius,
	(1+shift)*elongation*minor_radius
	)
	if self.configuration == "double-null":
	# upper_x_point is up-down symmetrical
	upper_x_point = (
	lower_x_point[0],
	-lower_x_point[1]
	)

The X points should be functions of vertical_displacement attribute

[shimwell]

Ah yes, I think the other plasma also ignores vertical_displacement

Perhaps this is just a simple addition or subtraction

[RemDelaporteMathurin]

It is, just put it there so I remember it :-)

[RemDelaporteMathurin]

Fixed in #156