New plasma shapes from RemiTheWarrior/plasma-boundaries

[RemDelaporteMathurin]

This PR includes new plasma shapes calculated from the plasmaboundaries package.

Usage:

from paramak import PlasmaBoundaries

myShape = PlasmaBoundaries(configuration="double-null")
myShape.export_2d_image("export.png")

Coverage:

94%

Fixes:

• BUG: wrong sign for lower_x_point #155
• BUG: vertical displacement not taken into account in compute_x_points() method #151

[shimwell]

Looks great, I have a few changes for the doc string. Nothing major

[shimwell]

Can we add something like

Uses the plasma boundaries package to calculate the points

[shimwell]

Do you think it is worth putting examples for ITER, DEMO etc in this file https://github.com/ukaea/paramak/blob/main/examples/example_parametric_components/make_plasmas.py

[shimwell]

This looks fine to me @RemiTheWarrior happy to merge if you are.

The other changes are optional ideas, nothing essential there

[RemDelaporteMathurin]

@shimwell i'll add a better summary in the docs a bit later 😄

[RemDelaporteMathurin]

Do you think it is worth putting examples for ITER, DEMO etc in this file https://github.com/ukaea/paramak/blob/main/examples/example_parametric_components/make_plasmas.py

@shimwell it can but I don't really see where to put things

[shimwell]

Do you think it is worth putting examples for ITER, DEMO etc in this file https://github.com/ukaea/paramak/blob/main/examples/example_parametric_components/make_plasmas.py

@shimwell it can but I don't really see where to put things

Ok I shall add to the example once it is merged. It will give me a good reason to get better at using this new plasma boundary parametric componet

[shimwell]

Do you think it is worth putting examples for ITER, DEMO etc in this file https://github.com/ukaea/paramak/blob/main/examples/example_parametric_components/make_plasmas.py

@shimwell it can but I don't really see where to put things

Ok I shall add to the example once it is merged. It will give me a good reason to get better at using this new plasma boundary parametric componet

I think you just added an example while I was typing the last reply :-)

[RemDelaporteMathurin]

I think you just added an example while I was typing the last reply :-)

I did, though something is messed up with my Docker installation as it seems it's using an old version of the branch somehow... Can you please test that the secondary bits of plasma don't appear on the png export ?

[RemDelaporteMathurin]

@shimwell this seems ok afterall (green curve is ITER single-null).

I think this is ready to be merged in if you're ok with it