New super

[shimwell]

This is just an idea to see what can be done about removing some unused arguments from the user view

[codecov-commenter]

Codecov Report

Merging #110 into develop will decrease coverage by 0.08%.
The diff coverage is 50.00%.

@@             Coverage Diff             @@
##           develop     #110      +/-   ##
===========================================
- Coverage    89.55%   89.47%   -0.09%     
===========================================
  Files           32       32              
  Lines         1944     1948       +4     
===========================================
+ Hits          1741     1743       +2     
- Misses         203      205       +2     

Impacted Files	Coverage Δ
...ramak/parametric_components/poloidal_field_coil.py	93.54% <50.00%> (-6.46%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8897e74...99b9af5. Read the comment docs.

[billingsley-john]

Looks great @shimwell. I like the look of this solution.

[shimwell]

What do people think, is this a better way to do things.

It avoids exposing the users to things they don't want or need.

Any feedback welcome

@RemiTheWarrior @bielsnohr @DeclanMorbey

[RemDelaporteMathurin]

@shimwell That's super and it simplifies things for users (as well as the docs!)

I reckon these can still be modified in the super class, right ?

[bielsnohr]

The alternative would be to collect these commonly unused arguments into a **kwargs, set the defaults in a dictionary below, and loop through the passed argument to modify those in the default dictionary, which is passed to super.__init__()

Something like (this could definitely be more pythonic, but you get the idea)

default_dict = {...fill in}

for arg in kwargs:
    if arg in default_dict:
        default_dict[arg] = kwargs[arg]

super().__init__(...args you have..., **default_dict)

This leaves open the option to set these at initialisation, but encourages against their use unless absolutely necessary.

[shimwell]

Thanks for the suggestion much appreciated, we can give this a go

[shimwell]

We have added kwargs to see how it looks :-)

[shimwell]

This can be closed now as the kwarg was implemented in #115