Feature reactor export stl #162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… into feature_reactor_export_stl
|
tests have been added |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is aiming to add the export_stl command to reactors so that it can be used in a similar way to the current reactor.export_stp
If this feature is merged before export_3d_image feature is removed in #150 then we can easily render reactor images using the stl files.
This has also become more interesting due to a potential ability to make h5m neutronics geometry directly from stl files as mentioned in #154 . Care must be taken to avoid overlapping geometry but that can be looked at in another PR
ToDo
add tests