Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: updating the Plasma() component #64

Merged

Conversation

RemDelaporteMathurin
Copy link

This PR includes an upgrade of the Plasma() component which is now based on parametric equations.

These equations take 4 geometrical parameters namely minor and major radii, elongation and triangularity.

Usage

import paramak

plasma = paramak.Plasma(minor_radius=200, major_radius=620, triangularity=0.55, elongation=1.85, rotation_angle=180)
plasma.solid

image

@RemDelaporteMathurin
Copy link
Author

@shimwell @billingsley-john since this PR removes things like plasma.radius_of_inside_arc , plasma.x_position_for_inside_arc, etc., it breaks the following test :

class test_CenterColumnShieldPlasmaHyperbola(unittest.TestCase):
def test_CenterColumnShieldPlasmaHyperbola_creation(self):
"""creates a CenterColumnShieldPlasmaHyperbola object and checks a solid is created"""
test_shape = paramak.CenterColumnShieldPlasmaHyperbola(
inner_radius=50, height=800, mid_offset=40, edge_offset=30
)
assert test_shape.solid is not None
assert test_shape.volume > 1000

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants