Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature/RR-1334-exclude-legacy-hvc #5297

Merged
merged 2 commits into from
Mar 28, 2024

Conversation

chopkinsmade
Copy link
Contributor

@chopkinsmade chopkinsmade commented Mar 27, 2024

Description of change

Add the ability to exclude the existing HVC items from the datahub dataset response. This is needed to avoid duplication in the data flow pipelines as the export wins API also returns these values.

Calling this url will /v4/dataset/export-wins-hvc-dataset?exclude_legacy=true only return HVC items added directly into datahub, and exclude the items added from EW

Checklist

  • Has this branch been rebased on top of the current main branch?

    Explanation

    The branch should not be stale or have conflicts at the time reviews are requested.

  • Is the CircleCI build passing?

General points

Other things to check

  • Make sure fixtures/test_data.yaml is maintained when updating models
  • Consider the admin site when making changes to models
  • Use select-/prefetch-related field lists in views and search apps, and update them when fields are added
  • Make sure the README is updated e.g. when adding new environment variables

See docs/CONTRIBUTING.md for more guidelines.

@chopkinsmade chopkinsmade marked this pull request as ready for review March 27, 2024 16:38
@chopkinsmade chopkinsmade requested a review from a team as a code owner March 27, 2024 16:38
Copy link

codecov bot commented Mar 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.46%. Comparing base (e033009) to head (2988084).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5297   +/-   ##
=======================================
  Coverage   96.46%   96.46%           
=======================================
  Files         922      922           
  Lines       21854    21859    +5     
  Branches     1954     1955    +1     
=======================================
+ Hits        21082    21087    +5     
  Misses        625      625           
  Partials      147      147           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@chopkinsmade chopkinsmade merged commit 823ed78 into main Mar 28, 2024
4 checks passed
@chopkinsmade chopkinsmade deleted the feature/RR-1334-exclude-legacy-hvc branch March 28, 2024 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants