Adding exception for staff user for analytics #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…henticated_staff_user' into GP2-3054_GA360_exception_for_authenticated_staff_user # Conflicts: # tests/test_mixins.py
depsiatwal
reviewed
Jun 17, 2021
great_components/mixins.py
Outdated
| @@ -75,6 +75,6 @@ def get_context_data(self, *args, **kwargs): | |||
| user = helpers.get_user(self.request) | |||
| is_logged_in = helpers.get_is_authenticated(self.request) | |||
| self.ga360_payload['login_status'] = is_logged_in | |||
| self.ga360_payload['user_id'] = user.hashed_uuid if is_logged_in else None | |||
| self.ga360_payload['user_id'] = user.hashed_uuid if (is_logged_in and not user.is_staff) else None | |||
There was a problem hiding this comment.
does this mean I can't be a staff user and a business user ?
There was a problem hiding this comment.
you can but for staff users, we are just adding user_id to None for google analytics as I dont think we should record staff visit to GA
This will resolve the issue while admin user not have UUID
There was a problem hiding this comment.
ok @depsiatwal amended for admin users only
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To do (delete all that do not apply):