Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TP2000-1334 Geo area exclusions front-end validation #1239

Merged
merged 17 commits into from
Jul 11, 2024

Conversation

eadpearce
Copy link
Contributor

TP2000-1334 Geo area exclusions front-end validation

Why

  • The list of geo area exclusions was not updated to match the members of a group when a group was selected
  • This ended up causing errors right at the end of the measure creation journey, wasting a lot of the user's time
  • To avoid this we can do filtering on the form fields on the front-end with react components

What

  • Replaces the current form field with a react version that filters the exclusions by the selected group in real time
  • Form still functions when JS is disabled

Checklist

  • Requires migrations? ❌
  • Requires dependency updates? ✅ in package.json
Screenshot 2024-05-30 at 14 19 19 Screenshot 2024-05-30 at 14 19 27

@eadpearce eadpearce requested a review from a team as a code owner May 30, 2024 13:25
common/static/common/js/components/SubmitButton/index.js Outdated Show resolved Hide resolved
geo_areas/constants.py Outdated Show resolved Hide resolved
measures/forms.py Outdated Show resolved Hide resolved
@eadpearce eadpearce force-pushed the TP2000-1334-geo-area-validation branch from 3fefe8c to 4f215b3 Compare July 9, 2024 15:54
@eadpearce eadpearce force-pushed the TP2000-1334-geo-area-validation branch from fde54e1 to 872207c Compare July 9, 2024 16:02
@eadpearce eadpearce force-pushed the TP2000-1334-geo-area-validation branch from fc1763c to 0b4e463 Compare July 10, 2024 15:06
@eadpearce eadpearce merged commit 9280826 into master Jul 11, 2024
8 checks passed
@eadpearce eadpearce deleted the TP2000-1334-geo-area-validation branch July 11, 2024 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants