Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TP2000-1402 Implement journey to create quota suspension or blocking periods #1252

Merged
merged 11 commits into from
Jun 21, 2024
Merged

TP2000-1402 Implement journey to create quota suspension or blocking periods #1252

merged 11 commits into from
Jun 21, 2024

Conversation

dalecannon
Copy link
Contributor

@dalecannon dalecannon commented Jun 18, 2024 •
edited
Loading

TP2000-1402 Implement journey to create quota suspension or blocking periods

Why

There is currently no way to create quota suspension or blocking periods in the UI.

What

  • Adds QuotaSuspensionOrBlockingCreate view & form
  • Adds QuotaSuspensionConfirmCreate & QuotaBlockingConfirmCreate views
  • Links to the create form on the actions menu on the quota detail view
  • Adds view and form unit tests

Screenshots

Screenshot 2024-06-18 at 16 59 45
Screenshot 2024-06-18 at 17 00 24
Screenshot 2024-06-20 at 13 52 23
Screenshot 2024-06-18 at 17 01 26
Screenshot 2024-06-18 at 17 02 03

@dalecannon dalecannon marked this pull request as ready for review June 20, 2024 13:04
@dalecannon dalecannon requested a review from a team as a code owner June 20, 2024 13:04
LaurenMullally
LaurenMullally approved these changes Jun 21, 2024
View reviewed changes
Copy link
Contributor

@LaurenMullally LaurenMullally left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks really good to me Dale! Great test coverage too!

@dalecannon dalecannon merged commit a4ee488 into master Jun 21, 2024
8 checks passed
@dalecannon dalecannon deleted the TP2000-1402--create-suspension-or-blocking-periods branch June 21, 2024 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LaurenMullally LaurenMullally LaurenMullally approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dalecannon @LaurenMullally