Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TP2000-1500 Update find commodity code view #1299

Merged
merged 6 commits into from
Oct 1, 2024

Conversation

mattjamc
Copy link
Collaborator

@mattjamc mattjamc commented Sep 30, 2024

TP2000-1500 Update find commodity code view

Why

Users need some additional filters and information on the Find a Commodity code view.

What

This PR:

  • updates styling of the search and filter panel as per design
  • adds in columns for start date and end date
  • allows filtering by commodity codes with an end date
  • fixes an unrelated quota test that is failing

Currently
image

Update with this PR
image

@@ -794,21 +794,22 @@ def test_sub_quota_update_form_valid(session_request_with_workbasket, sub_quota)
sub_quota_relation_type="EQ",
coefficient=1.5,
)

Copy link
Collaborator Author

@mattjamc mattjamc Sep 30, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file is unrelated to the ticket but it's a failing test from my last PR (which didn't fail before I merged it but I've fixed it now anyway)

@mattjamc mattjamc marked this pull request as ready for review September 30, 2024 14:04
@mattjamc mattjamc requested a review from a team as a code owner September 30, 2024 14:04
Copy link
Collaborator

@CPrich905 CPrich905 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, dwisott

@mattjamc mattjamc merged commit 21653dd into master Oct 1, 2024
8 checks passed
@mattjamc mattjamc deleted the TP2000-1500-update-find-commodity-code-view branch October 1, 2024 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants