Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review the permission logic on Watched Target status #588

Closed
anjackson opened this issue May 10, 2018 · 3 comments
Closed

Review the permission logic on Watched Target status #588

anjackson opened this issue May 10, 2018 · 3 comments

Comments

@anjackson
Copy link
Contributor

We've found a Target that appears to be Watched but should not be. Even the Archivist role cannot remedy this, as currently:

you can only edit these settings if your account has been permitted access to the Document Harvester, and if you own this target.

This should be reviewed, and the Archivist role should be able to override this.

@crarugal
Copy link

I've chosen webarchive.org.uk/act/targets/86223 as an example of a watched target, owned by the NLS Curator

Screenshot 2019-06-27 15 11 15

With an Archivist role, I can deselect the target and add a revision log

Screenshot 2019-06-27 15 13 17

As you can see, it no longer appears in the list of Watched Targets for the user (would have been first on list)
Screenshot 2019-06-27 15 13 55

Changing the target again so that it's now selected and Watched. However, as I am not the owner of the target I am unable to include extra metadata (which is correct).
Screenshot 2019-06-27 15 17 32

Could this a potential issue as a Watched Target could be deselected then selected again without the Target owner's knowledge and missing the required information:
Screenshot 2019-06-27 15 17 32

As opposed to the original metadata:
Screenshot 2019-06-27 15 12 16 - Copy

Creating and changing a Watched Target for a Target I own looks as though it's working as expected:
Screenshot 2019-06-27 15 22 54
Screenshot 2019-06-27 15 26 03

@min2ha
Copy link
Contributor

min2ha commented Jun 28, 2019

@crarugal actually current issue is related to allow users with archivist role to take over the control of target if the target owner cannot do it (due to some personal reasons, not technical), i.e. in this particular case to (de)select Watched Status of any target. I think your observations could be discussed later and its related to curator permission management logic, so new ticket should be created if agreed. And this issue was tested and should be closed.

@nicolabingham
Copy link

@crarugal it's fine that only the Archivist can take control of /reassign a WT. The workflow envisages that we communicate outside of ACT with Target owners about the WT status. Ownership and editorial control of WTs should be a lot more "locked down" than Targets, under the supervisions of the business owners (e.g. Official Publications) and the Archivists.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants