bccomp with scale parameter #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
July 2, 2015 17:25
|
@xeviplana you're totally right, thanks for the contribution! Are you using this library? |
acasademont
added a commit
that referenced
this pull request
Jul 2, 2015
bccomp with scale parameter
|
No problem, thank you for accepting the PR :) Yes, we're using it! It's the simplest I could find and it solves our problems quite well. Keep the good work! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I think it makes no sense that all the operations are made with the SCALE parameter, and then when these numbers are compared it is done without the same SCALE. This leads to invalid results, since the numbers are compared ignoring their decimal part.
According to the official PHP documentation (http://php.net/manual/en/function.bccomp.php):
With this fix, bccomp will know that for instance 1.22 is greater than 1.11.